slachiewicz commented on PR #71:
URL: https://github.com/apache/maven-doxia-site/pull/71#issuecomment-5230875223
Closing this — CI proved the approach wrong, and usefully so.
Routing the build through `fail-fast-build` does not just run `ff-goal`.
That job has a second, **unconditional** step:
```yaml
- name: Build with Maven
run: ./mvnw ... ${{ inputs.ff-goal }}
- name: Build Maven Site
run: ./mvnw ... ${{ inputs.ff-site-goal }}
```
`ff-site-goal` defaults to `-DskipTests -P reporting compile site
site:stage` and there is no input to suppress it. So this PR silently switched
that on. `clean site` passed; `site:stage` then failed:
```
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-site-plugin:3.22.0:stage (default-cli)
on project doxia-site: Error uploading site: Error copying directory
structure:
Unknown file type: .../target/site/doxia-tools-archives
```
That is a pre-existing problem in this repository's site output, unrelated
to the gating question, but it means there is no caller-side configuration here
that both keeps the current single `clean site` build and gets the correct skip
behaviour.
The underlying issue is still real: with `ff-run: false`, `verify`'s
condition
```yaml
(!cancelled()) && inputs.matrix-enabled && ( !inputs.ff-run ||
needs.fail-fast-build.result == 'success' )
```
is satisfied regardless of `setup-maven-version` having been skipped, and
its matrix then reads
`fromJSON(needs.setup-maven-version.outputs.maven-matrix)` from a job that
never ran. It only bites pull requests opened from a branch in this repository,
not from a fork.
So it belongs in `maven-gh-actions-shared` instead, as
`needs.setup-maven-version.result == 'success'` in `verify`'s condition.
Opening that there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
