slachiewicz opened a new pull request, #1679: URL: https://github.com/apache/maven-dependency-plugin/pull/1679
> **Last of a three-part split of #1677.** Base is `agent/mdep-get-test-hardening`, so this PR also carries #1677's commit — **the payload is the last commit only**. Merge order: #1678 → #1677 → this. Nothing needs `LegacyRepositorySystem` any more once `dependency:get` stops using `org.apache.maven.repository.RepositorySystem` (#1677) — that interface's only implementation is the one `maven-compat` supplies. I checked the dependency direction rather than assuming it. With `maven-compat` removed from the pom and the vendored class in place, but `GetMojo` unchanged, `TestCopyDependenciesMojo2` passes 13/13 while all four `TestGetMojo` tests fail to provision the mojo. So this genuinely cannot land before #1677, and it is the only part of the original PR that had to wait. ### The one judgement call `SnapshotArtifactRepositoryMetadata` is copied into the test tree rather than deleting its two usages. `TestCopyDependenciesMojo2.assertArtifactExists` iterates `artifact.getMetadataList()` and asserts a file exists — dropping the attachment leaves that loop empty and silently removes the check, which is worse than vendoring. The whole hierarchy above the class is in maven-core; only the leaf is compat-only. Same approach as MPLUGIN-384. Happy to drop the vendoring and weaken that assertion instead if the preference is to keep the test tree free of copied classes. 417 unit tests pass. <sub>Drafted with Claude — please verify</sub> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
