wilx commented on PR #1668: URL: https://github.com/apache/maven-dependency-plugin/pull/1668#issuecomment-5233784994
Thanks for the detailed review. I reproduced and addressed all nine points on the rebased branch: 1. Purge collection now uses a root `Dependency` when applying the filter, so Resolver derives its scope and optional selectors. The IT covers direct `test`/`provided` dependencies and an optional transitive dependency. 2. Short `dependency:get` coordinates now retain separately supplied `packaging` and `classifier`; explicit coordinate tokens still take precedence. Both directions are unit-tested. 3. Repository-layout installation preserves the active local repository manager's content type (`simple`, or Maven's `enhanced` mapped to its public `default` type). Both manager types are tested. 4. `GetMojo` validates the complete coordinate after parsing, including the required version. 5. Purge fallback reuses the Resolver dependency artifact, retaining classifier and type-derived extension. The bad-descriptor IT now exercises a `sources` artifact. 6. Installation includes each companion POM represented by `ProjectArtifactMetadata`; this is covered at the install request level and by repository-layout output assertions. 7. Both the transitive collection failure and per-artifact fallback failure retain their original exception in debug logging. 8. `GetMojo` now uses the Resolver session's repositories and `ResolverUtil` parser, including `id::url`; the legacy repository-system/layout/auth stack and its now-unused dependencies are gone. 9. The helper is now explicitly `localRepositorySession(File)` and rejects null. One shared-helper interaction also surfaced during the full IT run: `go-offline` needs a non-resolved root artifact, whereas filtered purge resolution needs a root dependency. Those contracts are now separate and covered by a unit regression plus both `go-offline` ITs. Verification on the final head: - `nice mvn clean verify`: 425 tests, 0 failures/errors, 1 existing skip - `nice mvn clean -Prun-its verify`: 94 passed, 0 failures/errors, 5 JRE-conditioned skips - focused Maven 4/JDK 21 tests: 34 passed - `spotless:check` on every commit revision -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
