slachiewicz opened a new pull request, #294: URL: https://github.com/apache/maven-remote-resources-plugin/pull/294
Moves the 10 `AbstractIT`-derived test classes under `src/test/java/.../it/` (run by failsafe under the `run-its` profile) from JUnit 4 to Jupiter: `@Before` → `@BeforeEach`, `Assert.*` → `Assertions.*`, `Assume.assumeTrue` → `Assumptions.assumeTrue`. No assertion in this module passed a message, so there was no argument-order flip to get wrong. `src/it/**` is untouched — that is a separate maven-invoker-plugin sample-project tree, not this suite. **Deliberately not migrated: `RemoteResourcesMojoTest`.** It extends `AbstractMojoTestCase` → `PlexusTestCase` (JUnit 3 style, `testXxx()` methods). maven-plugin-testing-harness 3.5.1 does ship a JUnit 5 path (`@MojoTest`/`@InjectMojo`/`@MojoParameter`), so this is not a blocked dependency — but this test builds differently-configured mojo instances per test via `lookupMojo()` + `setVariableValueToObject()` with runtime-computed session and repository state, which does not map onto that declarative model without a real redesign. That is out of scope for a mechanical migration and wants its own change. Because that class stays, `junit:junit` stays too, and `junit-vintage-engine` is added so it remains discoverable once surefire switches to `JUnitPlatformProvider`. Both are added to the existing `analyze-only` `ignoredDependencies`, since they are reached by ServiceLoader rather than by bytecode reference and `failOnWarning` is on. ### Verification `mvn test` before and after: `Tests run: 10, Failures: 0, Errors: 0, Skipped: 0`. `mvn -Prun-its verify` before and after: surefire 10/10, failsafe 9/9, identical. That run also shows 5 pre-existing failures in the `src/it` invoker projects (a Groovy verify-script resolution error) which are present on `master` too and are unrelated to this change. Draft until CI confirms. Generated-by: Claude Opus 5 (1M context) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
