wilx opened a new pull request, #1680:
URL: https://github.com/apache/maven-dependency-plugin/pull/1680
> [!IMPORTANT]
> This PR is stacked on top of #1677 and is the stacked alternative to
#1668. Until #1677 is merged, GitHub's diff also includes its two commits.
After #1677 is merged, this PR should contain only the five follow-up commits
described below. If this stacked approach is preferred, #1668 can be closed.
## Summary
Complete the Maven Artifact Transfer removal after #1677:
- migrate repository-layout installation in `dependency:copy-dependencies`
to Maven Resolver while preserving local-repository metadata, copied POMs,
snapshot base versions, and repository content type;
- migrate `dependency:purge-local-repository` resolution while preserving
filtering, fallback resolution, classifiers, and aggregated failure reporting;
- remove the now-unused `maven-artifact-transfer` dependency and
`DependableCoordinate` implementation;
- preserve `dependency:get`'s historical unconditional refresh policy for
explicitly supplied repositories while leaving other `ResolverUtil` callers
session-controlled;
- preserve separately configured packaging and classifier values for short
artifact coordinates, with explicit coordinate segments retaining precedence.
The repository parsing, strict artifact-coordinate validation, and
`dependency:get` Resolver migration come from #1677.
Fixes #1355
## Verification
- Maven 3/JDK 21: `nice mvn clean verify` — 434 tests, 0 failures/errors, 1
skipped; dependency analysis clean
- Maven 3/JDK 21: `nice mvn clean -Prun-its verify` — 99 Invoker projects
passed, 0 failed/errors/skipped
- Maven 4/JDK 21: focused `TestGetMojo`, `ResolverUtilTest`, and
`TestCopyDependenciesMojo2` clean run — 43 tests, 0 failures/errors/skips
- Maven 3/JDK 21: focused `get-*` Invoker run — 4 passed, 0
failed/errors/skipped
- `spotless:check` passed on every follow-up commit revision; `git diff
--check` passed on the final head
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Your pull request should address just one issue, without pulling in
other changes.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
Note that commits might be squashed by a maintainer on merge.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
- [x] Run `mvn verify` to make sure basic checks pass.
A more thorough check will be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
