slachiewicz opened a new pull request, #391:
URL: https://github.com/apache/maven-archiver/pull/391
`src/site/xdoc/index.xml.vm` was the last xdoc content page left in this
repository. It becomes `src/site/markdown/index.md.vm`, rendering to the same
`index.html`.
The page is three configuration tables whose cells hold nested lists and
code blocks, plus a code block with links into those tables. A Markdown table
cannot hold either -- `doxia-converter` emits cells broken across lines and
drops the links with *"Ignoring unsupported link inside code block"* -- so the
tables and the code blocks are carried over as inline HTML. Doxia parses them
back into the same events the xdoc parser produced, so the rendered markup is
unchanged, striped row classes and `prettyprint linenums` included.
The `<a name="...">` anchors that the tables link to (`#class_archive`,
`#class_manifest`, `#class_manifestSection`, `#pom-properties-content`) sit at
the end of the preceding HTML block rather than on a line of their own. On
their own line Markdown wraps them in a paragraph, which both adds an empty
paragraph and costs the subsection its own generated id.
The file stays a Velocity template, so the headings below the title use a
setext underline -- `##` is a Velocity line comment and would delete the
heading silently. The manifest entries the page documents are escaped with
`${esc.d}` rather than a backslash.
### Verification
`mvn site` was run on `master` and on this branch and the generated HTML
compared:
- page title, `meta name="author"`, visible text and every link target:
identical
- the full set of anchor ids on the page: identical
- every other page of the site: identical
- the remaining differences in the raw markup are whitespace and a `<tbody>`
that Doxia now emits around each table
### Please do not squash
The rename is a separate commit so `git log --follow` keeps working.
Squashing collapses it back into a delete plus an add.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
