slachiewicz opened a new pull request, #919:
URL: https://github.com/apache/maven-wagon/pull/919

   `wagon-providers/wagon-ssh/src/site/xdoc/configuration.xml` was the last 
xdoc content page left in this repository. It becomes 
`src/site/markdown/configuration.md`, rendering to the same 
`configuration.html`.
   
   The page is one table whose cells hold nested lists and paragraphs, which a 
Markdown table cannot express -- `doxia-converter` emits cells broken across 
lines and the table falls apart. The table is therefore carried over as inline 
HTML. Doxia parses it back into the same table events the xdoc parser produced, 
so the rendered markup is unchanged, striped row classes included.
   
   ### One content change
   
   The page carried the same `Configuration` section **twice** -- the whole 
table, verbatim, in two `<section name="Configuration">` blocks. It has been 
that way since `46ad4093` ("Fix the wagon site"), so it looks like an old 
copy-paste rather than anything intended. Only one copy is kept here.
   
   Doxia had been numbering the second heading, so the page had an 
`#Configuration_1` anchor. An explicit `<a name="Configuration_1"></a>` keeps 
that anchor resolving, so no inbound deep link breaks.
   
   If you would rather keep both copies and change nothing, say so and I will 
restore the duplicate.
   
   ### Verification
   
   `mvn site` was run on `master` and on this branch and the generated HTML 
compared:
   
   - page title, `meta name="author"`, visible text and every link target: 
identical, apart from the removed duplicate section
   - anchor ids on the page: `Configuration` and `Configuration_1`, the same 
set as before
   
   ### Please do not squash
   
   The rename is a separate commit so `git log --follow` keeps working. 
Squashing collapses it back into a delete plus an add.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to