ascheman commented on PR #3352: URL: https://github.com/apache/maven-surefire/pull/3352#issuecomment-5245583078
@Bukama thanks for the rebase — I looked at why all nine `4.0.0-rc-6` legs are red. Two independent causes, both fixable: ### 1. The matrix exclude doesn't match The shared workflow expands the Maven 4 cell with the exact version string from `maven4-version` (currently [`4.0.0-rc-6`](https://github.com/apache/maven-gh-actions-shared/blob/v4/.github/workflows/maven-verify.yml)), so `"maven": "4"` never matches and the JDK 11 cells run anyway, dying at "Maven 4.x requires Java 17". Same issue Guillaume fixed for rc-5 back in July. The JDK 8 entry is redundant — the shared workflow auto-excludes JDK 8 when `maven4-enabled` is set. So: ```yaml matrix-exclude: '[ { "jdk": "11", "maven": "4.0.0-rc-6" } ]' ``` (Since the version string is hard-coded, this needs a touch-up whenever `maven4-version` moves, e.g. at GA. Pinning `maven4-version: '4.0.0-rc-6'` here as well would at least keep the two in sync visibly.) ### 2. The rebase dropped Guillaume's IT launcher workaround The jdk-17/21 legs fail with 437 IT errors (`SurefireVerifier Failed to execute Maven`): that's the known `maven-verifier 2.0.0-M1` embedded-mode incompatibility again — `Embedded3xLauncher` reflects on `MavenCli#doMain(...)`, which Maven 4 replaced with `MavenCling`. Guillaume's force-push from July had a workaround (detect Maven 4 in `MavenLauncher`, force `forkJvm=true`) plus a `CountdownCloseable` spurious-wakeup fix, but those commits never landed on master and are gone from this PR after the rebase. I'd suggest re-rolling that workaround as a standalone PR against master so it can't get lost in the next rebase here — happy to prepare that. Long term the fix remains the migration from the deprecated `maven-verifier` to [`maven-executor`](https://github.com/apache/maven-executor), which supports Maven 3 and 4 natively (apache/maven-verifier#186). On the positive side: the 20 exit-code-2 failures (`${surefire.threadNumber}` eval expansion in the rc-5 `mvn` script) are gone with rc-6, as predicted. With the two fixes above, the remaining delta should be down to the ~36 genuine Maven 4 behavioral differences Guillaume catalogued. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
