wilx opened a new pull request, #419:
URL: https://github.com/apache/maven-help-plugin/pull/419

   ## Summary
   
   Fixes #367 for 3.x branch.
   
   This backports the lifecycle-mapping part of #372 to the 
`maven-help-plugin-3.4.x` maintenance branch. Maven 3.10 represents the default 
lifecycle's built-in bindings as an empty map. The 3.x implementation only fell 
back to the packaging-specific mapping when that map was `null`, so 
`help:describe -Dcmd=deploy` reported every phase as `Not defined` and the 
existing `describe-cmd` integration test failed in [this Actions 
job](https://github.com/apache/maven-help-plugin/actions/runs/31315017957/job/93589464831).
   
   The change treats both null and empty built-in mappings as 
packaging-specific and replaces the deprecated string lifecycle APIs with their 
typed equivalents. Those APIs were verified against Maven 3.6.3, the minimum 
version declared by this branch.
   
   The commits are intentionally split: the first adds a unit regression that 
fails without the runtime change, and the second applies the fix. The existing 
`describe-cmd` IT provides end-to-end coverage of the reported failure.
   
   ## Validation
   
   - Maven 3.6.3 / JDK 8: `mvn clean verify` — 24 unit tests passed
   - Maven 3.9.16 / JDK 21: `mvn clean verify -P run-its` — 24 unit tests and 
all 34 ITs passed
   - Maven 3.10.0-rc-1 / JDK 17: `mvn clean verify -P run-its` — 24 unit tests 
and all 34 ITs passed, including `describe-cmd`
   
   ## Checklist
   
   - [x] This pull request addresses one issue without unrelated changes.
   - [x] The description explains what changed, how, and why.
   - [x] Each commit has a meaningful subject line and body.
   - [x] A regression unit test fails without the runtime change.
   - [x] `mvn verify` was run successfully.
   - [x] The integration tests were run successfully with `mvn -Prun-its 
verify`.
   
   - [x] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0).
   - [ ] In any other case, an [Apache Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) has been filed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to