kec commented on PR #12732: URL: https://github.com/apache/maven/pull/12732#issuecomment-5294585674
Reporter of #12731 here. Two things that might help this land in a release. **Milestone.** This PR is currently unmilestoned — would 4.0.0-rc-7 (milestone 131) be reasonable? The failure mode is an indefinite hang with no output and no exception under `-T`, so in unattended CI an affected build holds an agent until something external kills it; there is nothing to react to. We hit it twice on rc-5 — once as this hang, once weeks earlier as a `ConcurrentModificationException` from the same call path — and rc-6 carries the same code. **Completing the fix.** @gnodet's review flagged that the deprecated compat copy at `compat/maven-model-builder/src/main/java/org/apache/maven/model/interpolation/reflection/ReflectionValueExtractor.java:54` has the identical unsynchronized `WeakHashMap` and the same non-atomic `getClassMap`, still reachable through `ObjectBasedValueSource`. I have that change ready in exactly the form used here. Happy to send it either way: - as a PR against `waterWang:fix/reflection-weak-hashmap-concurrency`, keeping this a single commit, or - as a companion PR once this one merges. @waterWang — your call; say which you'd prefer and I'll open it. I can also attach the full thread dump from the original incident to #12731 if that is useful for the record. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
