elharo commented on code in PR #1667: URL: https://github.com/apache/maven-dependency-plugin/pull/1667#discussion_r3825363943
########## src/main/java/org/apache/maven/plugins/dependency/fromConfiguration/ClasspathScope.java: ########## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.maven.plugins.dependency.fromConfiguration; + +import java.util.Locale; + +import org.eclipse.aether.util.artifact.JavaScopes; + +enum ClasspathScope { + COMPILE, + RUNTIME, + TEST; + + static ClasspathScope fromString(String value) { + try { + return valueOf(value.toUpperCase(Locale.ROOT)); + } catch (IllegalArgumentException e) { + throw new IllegalArgumentException( + "Unknown dependency scope '" + value + "'. Expected one of: compile, runtime, test.", e); Review Comment: Yes, in this case the bug is really here in this method, not inside the Enum code, so there doesn't seem to be any benefit to wrapping the original exception. The stack trace will be cleaner and point more directly to the real issue if we just throw an exception here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
