skrcode commented on PR #427: URL: https://github.com/apache/maven-install-plugin/pull/427#issuecomment-5384083509
I ran JAIPilot Cloud against this exact PR head. It exposed a parallel first-fill race in the new cache: with eight simultaneous module mojos, the current get/check/put sequence can make every caller repeat the full reactor scan before any result is published. In a barrier-controlled proof, the exact head produced 8 scans and 8 list instances in 25/25 repetitions. A computeIfAbsent candidate produced 1 scan and 1 shared instance in 30+ repetitions. Eight behavior tests preserved empty-reactor handling, filtering and order, and single-thread reuse; mvn clean verify passed 22 tests plus Checkstyle, Spotless, RAT, and jar construction. Cloud-generated draft and full evidence: https://github.com/skrcode/maven-install-plugin/pull/2 Important delivery caveat: Maven DefaultSession currently delegates to a MavenSession plugin context backed by ConcurrentHashMap, but org.apache.maven.api.Session exposes only Map. The generated patch casts that result to ConcurrentMap, and its draft overstates what every generic ConcurrentMap implementation guarantees about mapping-function invocation. The race evidence is useful, but I am not presenting this patch as ready to merge until the implementation-contract choice and wording are resolved by Maven maintainers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
