HuzaifaChaudary commented on PR #13055:
URL: https://github.com/apache/maven/pull/13055#issuecomment-5561442665

   you are right . once there is more than one failure the wrapper is a checked 
exception , so the error inside it stops counting as fatal and under -fae the 
project is only blacklisted . pushed a fix that reads the halt from the 
failures rather than from the wrapper . with a single failure it comes out to 
the same check as before , so nothing else moves . the new test fails without 
it .
   
   being straight about the test though , it does not drive a real after:* 
failure . a step with no mojo cannot be made to throw in this harness , so the 
second failure is put on the after:validate step the same way the cleanup catch 
stores it . the collecting , the wrapping and the halt decision all run for 
real , but the cleanup step is not what raises it .
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to