gnodet commented on PR #13080:
URL: https://github.com/apache/maven/pull/13080#issuecomment-5614101898
All review feedback addressed in f0bc8d231e:
1. **Placeholder guard** — `version()` now fails fast with
`ExceptionInInitializerError` if a value still looks like `${…}` (unfiltered)
2. **Private `version()`** — method is now `private`; the public constants
are the only API
3. **Unit test** — `PluginVersionsTest` reflectively asserts all `public
static final String` fields are non-null and not unfiltered placeholders, with
a floor check (≥ 13 constants)
4. **Bot visibility** — added `<pluginManagement>` block with all 13 plugins
referencing `${version.maven-*-plugin}` properties, so Dependabot/Renovate can
track them as real plugin declarations
5. **Key naming alignment** — properties file keys now use
`version.maven-<name>-plugin` (matching the POM property names) instead of
`maven-<name>-plugin.version`
6. **Field deprecation** — all 11 `protected static final` version fields in
`AbstractLifecycleMappingProvider` annotated with `@Deprecated(since = "4.1.0",
forRemoval = true)`, pointing to `PluginVersions.*` replacements
_This comment was generated by an AI agent, Hermès, on behalf of @gnodet._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
