goutamadwant opened a new pull request, #13104:
URL: https://github.com/apache/maven/pull/13104
Fixes #8682.
Replace recursive parent-model assembly and parent-project initialization
with explicit traversal frames. This removes the Java stack-depth limit from
the reported fully specified parent hierarchy while retaining inheritance
order, profile recording and cache replay, repository propagation, parent
fallback, supplied project identity, and classloader restoration.
Track active sources and resolved coordinates during cache-miss assembly so
external mixin cycles fail promptly, including resolvers returning opaque
in-memory sources. Completed sources can still be reused. Classifier and
extension are part of the resolved identity; display locations are not treated
as unique identifiers.
The 1,000-parent reproducer fails with StackOverflowError before the change
and passes afterward with a 1 MiB thread stack. Regression tests also cover
shallow ancestry, inherited properties, profile/cache behavior, cycle cleanup,
mixin precedence, and parent-build failures. This does not remove separate
recursion for module traversal or inferred parent coordinates.
Validation with JDK 21: focused and affected-module checks passed. The full
`mvn -B -ntp -Prun-its -Dits.forkCount=2 verify` passed, including the complete
reactor and 1,074 Core IT tests with no failures or errors (43 skipped).
<!--
Please open pull requests against one of the following branches:
- master — default target for all changes (new features + bug fixes).
If the change should also go to maven-4.0.x, request a backport in the PR.
- maven-3.10.x — target for 3.x changes (new features + bug fixes).
If the change should also go to maven-3.9.x, request a backport in the PR.
maven-3.9.x should receive only serious bug fixes, as it is approaching
EOL.
Backports are typically handled by maintainers;
however, after agreement you may open a separate backport PR to the target
maintenance branch.
-->
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Your pull request should address just one issue, without pulling in
other changes.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
Note that commits might be squashed by a maintainer on merge.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
- [x] Run `mvn verify` to make sure basic checks pass.
A more thorough check will be performed on your pull request automatically.
- [x] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
