gnodet commented on code in PR #13194: URL: https://github.com/apache/maven/pull/13194#discussion_r4052447663
########## its/core-it-suite/src/test/java/org/apache/maven/it/MavenITgh13192PomInlinerCiFriendlyPropertyTest.java: ########## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.maven.it; + +import java.nio.file.Files; +import java.nio.file.Path; + +import org.junit.jupiter.api.Test; + +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertTrue; + +/** + * Verifies that {@code PomInlinerTransformer} correctly inlines CI-friendly version properties + * (e.g. {@code ${revision}}) that are defined in the project's own {@code <properties>} section + * rather than being passed via {@code -Drevision=...} on the command line. + * + * <p>Prior to the fix, Maven 4 would throw + * {@code IllegalArgumentException: Cannot inline property revision} in legacy mode + * when {@code revision} was present only in POM properties.</p> + * + * @see <a href="https://github.com/apache/maven/issues/13192";>GH-13192</a> + */ +class MavenITgh13192PomInlinerCiFriendlyPropertyTest extends AbstractMavenIntegrationTestCase { + + MavenITgh13192PomInlinerCiFriendlyPropertyTest() {} Review Comment: The premise is still incorrect. `AbstractMavenIntegrationTestCase` in this codebase has **only one constructor**: `protected AbstractMavenIntegrationTestCase() {}` (line 44 of `its/core-it-support/maven-it-helper/src/main/java/org/apache/maven/it/AbstractMavenIntegrationTestCase.java`). There is no `protected AbstractMavenIntegrationTestCase(String versionRangeStr)` overload in this file. The cited evidence is also wrong: `MavenITgh13004ConsumerPomProfileArtifactIdTest` and `MavenITgh13068LegacyPluginDependenciesResolverTest` do **not** call `super(...)` with a version range — neither test has a constructor at all (they rely on the implicit no-arg default). Searching those files confirms this. The no-arg constructor in `MavenITgh13192PomInlinerCiFriendlyPropertyTest` is correct. CI is green on all 19 matrix jobs. Resolving this thread. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
