slachiewicz commented on PR #302: URL: https://github.com/apache/maven-dependency-analyzer/pull/302#issuecomment-5742851267
Thanks for the quick turnaround, but this can't land: #301's premise does not hold. `DefaultProjectDependenciesResolver` in maven-core 3.9.16 collects from `getDependencyArtifacts()` (already null here) or `getDependencies()`, never from `getArtifacts()`, so the new override is a no-op for the resolver, and the updated test only asserts the override itself. I built this branch as 1.17.3-SNAPSHOT and ran apache/maven-dependency-plugin's `analyze-testDependencyWithNonTestScope` IT against it: it fails identically to 1.17.2. The candidate in that IT is genuinely reachable at compile scope (`maven-project:2.0.6 → plexus-container-default → junit:3.8.1`), which is the case #294 was written to suppress. The fix belongs in the plugin IT; closing this together with #301. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
