gnodet-bot commented on code in PR #2157:
URL: https://github.com/apache/maven-resolver/pull/2157#discussion_r4081739566
##########
maven-resolver-named-locks-ipc/src/main/java/org/eclipse/aether/named/ipc/IpcServer.java:
##########
@@ -213,17 +218,16 @@ static IpcServer runServer(SocketFamily family, String
tmpAddress, String rand)
private static void debug(String msg, Object... args) {
if (DEBUG) {
- System.out.printf("[ipc] [debug] " + msg + "\n", args);
+ LOGGER.debug(msg, args);
Review Comment:
⚠️ **No SLF4J binding in forked process — messages silently dropped.**
When `IpcServer` is started as a subprocess (the default path), `IpcClient`
passes only the `maven-resolver-named-locks-ipc` jar on the classpath (see
`IpcClient.java:188`). `slf4j-api` is `provided` scope and `slf4j-simple` is
`test` scope — neither is present in the forked JVM. SLF4J 2.x falls back to a
no-op logger: this `LOGGER.info()` call produces no output. Before this PR,
`System.out.printf` wrote to `logFile` via
`ProcessBuilder.Redirect.to(logFile.toFile())` — that output is now gone.
The same applies to `LOGGER.debug()` and `LOGGER.error()` below. The
`error()` method previously printed a full stack trace via
`t.printStackTrace(System.out)`; that diagnostic is now silently lost.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
