gnodet-bot commented on code in PR #105: URL: https://github.com/apache/maven-clean-plugin/pull/105#discussion_r4082158677
########## src/it/multi-module-with-dependencies/verify.groovy: ########## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +// Verify that clean succeeds in a multi-module project where one module depends on +// another without attempting dependency resolution (MCLEAN-104). +// The clean lifecycle should not resolve dependencies, so module1 need not be installed. + Review Comment: 💡 **Add Maven version constraint to the test description.** The bug existed in 4.0.0-beta-1 and was fixed in `apache/maven#2124`. The comment should say which Maven version this IT is testing against (or that it verifies the fix is in place), so future readers understand the context. Also consider adding an `invoker.properties` with `invoker.maven.version` to constrain the IT to Maven 4.x only (since the issue was Maven 4-specific and 3.x never attempted this resolution). ########## src/it/multi-module-with-dependencies/pom.xml: ########## @@ -0,0 +1,52 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + + <groupId>test</groupId> + <artifactId>multi-module-with-dependencies</artifactId> + <version>1.0-SNAPSHOT</version> + <packaging>pom</packaging> + + <description>Verify that clean does not attempt dependency resolution in a multi-module project (MCLEAN-104).</description> + + <modules> + <module>module1</module> + <module>module2</module> + </modules> + + <properties> + <maven.compiler.source>17</maven.compiler.source> + <maven.compiler.target>17</maven.compiler.target> + <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> + </properties> + Review Comment: ⚠️ **Unnecessary compiler properties.** This IT has no Java sources — `clean` does not compile anything, so `maven.compiler.source`, `maven.compiler.target`, and `project.build.sourceEncoding` are never consulted. They also impose an artificial Java 17 floor on the test project and copy the exact same verbatim block from the issue report's original reproducer (which did have Java sources). Drop them. ```suggestion <properties> </properties> ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
