efegokdemir commented on PR #13251: URL: https://github.com/apache/maven/pull/13251#issuecomment-5797437687
Implemented the review follow-up in `768fbc1`: - `dryRun` is now derived centrally from the goal's existing persistence behavior in `AbstractUpgradeGoal`, removing the parallel `Check`/`Apply` state assignments. - `InferenceStrategy` now reports `would be applied` during `mvnup check` and retains `applied` for `mvnup apply`. Validation with JDK 21: - `mvn -pl impl/maven-cli -am -DskipITs -Dtest=CheckTest,ApplyTest,InferenceStrategyTest,StrategyOrchestratorTest,UpgradeContextTest -Dsurefire.failIfNoSpecifiedTests=false test` — PASS (36 tests) - `git diff --check` — PASS The follow-up commit is SSH-signed and DCO-signed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
