gnodet commented on PR #561: URL: https://github.com/apache/maven-jar-plugin/pull/561#issuecomment-5815266653
The upstream `master` branch has a significant merge conflict with this PR. The conflict is non-trivial: `master` has completely refactored `createArchive()` into a new `ToolExecutor`/`FileCollector`-based approach that no longer uses `MavenArchiver` or a `try/catch (Exception e)` block at all. As a result, this PR's change (narrowing the catch clause to `MavenArchiverException | ArchiverException`) is superseded by the upstream refactor — the code being changed no longer exists in `master`. Two possible paths forward: 1. **Close this PR** if the original issue (#559) is resolved by the refactor (the new code no longer swallows exceptions via an overly broad catch). 2. **Reassess** if the new `ToolExecutor`/`FileCollector` code has a similar issue and open a new targeted PR. The conflict cannot be auto-resolved — it requires a design decision from the author. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
