gnodet commented on issue #255: URL: https://github.com/apache/maven-filtering/issues/255#issuecomment-5822398221
After investigating the history of this issue: **Original issue (JAR-extracted file with 1980-epoch timestamp not copied):** Fixed since **3.3.2** — the combination of MSHARED-1285 (scanner overhaul) and MSHARED-1216 (switch to `CachingOutputStream`, removing `NOFOLLOW_LINKS`) means the current code follows symlinks when reading sources and uses content-based change detection, so the 1980-timestamp skip no longer occurs. **Antoine Tran's sub-issue (directories disappearing with relative symlinks in source tree):** Also addressed by the MSHARED-1285 scanner change in 3.3.2. **Current behavior (HEAD / 3.5.x):** `FilteringUtils.copyFile()` uses `Files.newOutputStream(to.toPath())` + `Files.copy(from.toPath(), os)` — both follow symlinks, so a symlink source is transparently read and its content is copied as a regular file to the destination. This matches the pre-3.2.0 behaviour from `maven-shared-utils`. Closing — both reported scenarios are fixed. If there are still concrete symlink edge cases to address, a fresh targeted issue would be cleaner than keeping this open. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
