ascheman commented on PR #13269: URL: https://github.com/apache/maven/pull/13269#issuecomment-5828911460
Heads-up: CI is red on this PR — `initial-build` fails at the `test-mvn-path-conversion` exec (project `apache-maven`), and it's caused by this change. All the path-*conversion* assertions pass (`ok - POSIX/CYGWIN/MINGW/MSYS …`); the script then aborts (it runs under `set -e`) at the first `-f` scenario: ```sh output=`run_mvn_with_args CYGWIN_NT-10.0 "$stub_dir" -f /cygdrive/c/temp/pom.xml validate` ``` Root cause: this PR makes a non-existent `-f`/`--file` a **fatal early exit** in the launcher — `find_file_argument_basedir`'s `exit 1` is now propagated up (the correct fix for the double-error). Previously that "POM file … does not exist" message was printed but **non-fatal**, so the launcher continued. `test-mvn-path-conversion.sh` passes **simulated, non-existent** `-f` paths — it only checks path *conversion*, with `java` stubbed, so the file never had to exist — and under `set -e` the now-fatal exit aborts the test before it can assert the conversion. The behavior change is right; the test just needs to catch up — e.g. `touch` a real file at each `-f` path the test passes (or point them at an existing stub) so the existence check passes and the conversion assertions still run. (`-s` scenarios are unaffected — settings files aren't existence-checked in the launcher.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
