gnodet-bot commented on code in PR #405:
URL: https://github.com/apache/maven-filtering/pull/405#discussion_r4102763662
##########
src/main/java/org/apache/maven/shared/filtering/DefaultMavenResourcesFiltering.java:
##########
@@ -67,13 +67,63 @@ public class DefaultMavenResourcesFiltering implements
MavenResourcesFiltering {
public DefaultMavenResourcesFiltering(MavenFileFilter mavenFileFilter,
BuildContext buildContext) {
this.mavenFileFilter = requireNonNull(mavenFileFilter);
this.buildContext = requireNonNull(buildContext);
- this.defaultNonFilteredFileExtensions = new ArrayList<>(5);
+ this.defaultNonFilteredFileExtensions = new ArrayList<>();
Review Comment:
💡 49 entries are being added; the default `ArrayList<>()` capacity is 10 → 3
resizings during construction.
```suggestion
this.defaultNonFilteredFileExtensions = new ArrayList<>(64);
```
##########
src/main/java/org/apache/maven/shared/filtering/DefaultMavenResourcesFiltering.java:
##########
@@ -67,13 +67,63 @@ public class DefaultMavenResourcesFiltering implements
MavenResourcesFiltering {
public DefaultMavenResourcesFiltering(MavenFileFilter mavenFileFilter,
BuildContext buildContext) {
this.mavenFileFilter = requireNonNull(mavenFileFilter);
this.buildContext = requireNonNull(buildContext);
- this.defaultNonFilteredFileExtensions = new ArrayList<>(5);
+ this.defaultNonFilteredFileExtensions = new ArrayList<>();
+ // Images
this.defaultNonFilteredFileExtensions.add("jpg");
this.defaultNonFilteredFileExtensions.add("jpeg");
this.defaultNonFilteredFileExtensions.add("gif");
this.defaultNonFilteredFileExtensions.add("bmp");
this.defaultNonFilteredFileExtensions.add("png");
this.defaultNonFilteredFileExtensions.add("ico");
+ this.defaultNonFilteredFileExtensions.add("webp");
+ this.defaultNonFilteredFileExtensions.add("tif");
+ this.defaultNonFilteredFileExtensions.add("tiff");
+ this.defaultNonFilteredFileExtensions.add("svg");
Review Comment:
💡 SVG is XML (text), not binary. A user who places an SVG template in a
filtered resource directory with `${project.version}` inside will get silent
non-filtering after this change — a behavioral regression for that (admittedly
niche) use case.
Worth a conscious decision: either keep it and document it, or drop `svg`
from the default list since users who want it excluded can still add it to
`nonFilteredFileExtensions`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
