gnodet-bot commented on code in PR #531:
URL:
https://github.com/apache/maven-resources-plugin/pull/531#discussion_r4104037621
##########
src/main/java/org/apache/maven/plugins/resources/ResourcesMojo.java:
##########
@@ -61,6 +61,26 @@ public class ResourcesMojo implements
org.apache.maven.api.plugin.Mojo {
@Parameter(defaultValue = "${project.build.sourceEncoding}")
protected String encoding;
+ /**
+ * The character encoding to use when writing filtered resources.
+ * When set, enables encoding conversion during filtering: resources are
read with {@link #encoding}
+ * and written with this encoding. Useful to convert legacy EBCDIC or
Latin-1 source files to UTF-8
+ * (or vice-versa) as part of the build.
+ * <p>
+ * When not set (the default), the same encoding is used for reading and
writing, preserving
+ * backward compatibility.
+ * </p>
+ * <p>
+ * This parameter is ignored when filtering is disabled (i.e. when no
resource has
+ * {@code <filtering>true</filtering>}), because non-filtered
files are always copied
+ * as raw bytes.
+ * </p>
+ *
+ * @since 3.4.1
Review Comment:
⚠️ **Inaccurate `@since` tag** — version `3.4.1` was never released
(releases went `3.4.0` → `3.5.0` → `3.5.1`). Since this PR targets `master`
(the 4.x line), this should be:
```suggestion
* @since 4.0.0-beta-2
```
If backporting to the 3.x line as well, use the future 3.x release version
there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
