desruisseaux commented on PR #1136: URL: https://github.com/apache/maven-compiler-plugin/pull/1136#issuecomment-5837025638
The rational for disabling incremental compilation when there is a `-proc only` option is also true for the case of a `-proc full` option: the latter could be for both collecting information on all classes *and* recompiling a few classes. Doing something different in the two cases is an heuristic rules with no guarantees to be true. Another inconsistency is that the current implementation modifies the configuration only when user did *not* specified explicitly an `incrementalCompilation` value (user configuration has precedence), while this pull request unconditionally discards user configuration in the `-proc only` case. I propose to revert the changes in the `amendincrementalCompilation` method. Instead, keep the currently existing `if` statement with a different body: delete the two `aspects.add` calls and put the `aspects.clear()` and the new `aspects.add(IncrementalBuild.Aspect.NONE)` instead. As an optimization, if the project is modular and there is no include/exclude filters, the option should be `MODULES` instead of `NONE`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
