desruisseaux commented on code in PR #610:
URL: https://github.com/apache/maven-jar-plugin/pull/610#discussion_r4115128597
##########
src/main/java/org/apache/maven/plugins/jar/ToolExecutor.java:
##########
@@ -69,6 +70,104 @@ final class ToolExecutor {
*/
private static final String CREATED_BY = "Created-By";
+ /**
+ * Matches any character that is not an ASCII letter or digit.
+ * Used by {@link #cleanModuleName(String)} to mirror the JDK's {@code
ModulePath.cleanModuleName()} algorithm.
+ */
+ private static final Pattern NON_ALPHANUM =
Pattern.compile("[^A-Za-z0-9]");
Review Comment:
Delete the two patterns if the `cleanModuleName` method is replaced as
suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
