gnodet-bot commented on code in PR #527:
URL:
https://github.com/apache/maven-resources-plugin/pull/527#discussion_r4117509425
##########
src/main/java/org/apache/maven/plugins/resources/ResourcesMojo.java:
##########
@@ -152,11 +153,34 @@ public class ResourcesMojo implements
org.apache.maven.api.plugin.Mojo {
@Parameter
protected String escapeString;
+ /**
+ * Strategy used to decide whether an existing destination file needs to
be overwritten.
+ * Accepted values:
+ * <ul>
+ * <li>{@code CONTENT} — (default) only overwrite when the content
differs (uses
+ * {@code CachingOutputStream} / {@code CachingWriter}); destination
timestamp is
+ * preserved when the content is identical. This is the behaviour
since 3.4.0.</li>
+ * <li>{@code TIMESTAMP} — only overwrite when the source is newer than
the destination
+ * (timestamp-based, as it was before 3.4.0).</li>
+ * <li>{@code TIMESTAMP_AND_CONTENT} — overwrite only when the source is
newer
+ * <em>and</em> the content differs.</li>
+ * <li>{@code ALWAYS} — always overwrite existing files (equivalent to
the former
+ * {@code <overwrite>true</overwrite>}).</li>
+ * <li>{@code NEVER} — never overwrite an existing destination file.</li>
+ * </ul>
+ *
+ * @since 3.4.0
Review Comment:
⚠️ **Regression from rebase (7th review):** `@since 3.4.0` is incorrect —
the `changeDetection` parameter is new in this PR. The milestone is
`4.0.0-beta-2`. This was fixed in `cf0b8a8`, lost in the first rebase, fixed
again, and lost in this rebase.
```suggestion
* @since 4.0.0-beta-2
```
##########
src/main/java/org/apache/maven/plugins/resources/ResourcesMojo.java:
##########
@@ -152,11 +153,34 @@ public class ResourcesMojo implements
org.apache.maven.api.plugin.Mojo {
@Parameter
protected String escapeString;
+ /**
+ * Strategy used to decide whether an existing destination file needs to
be overwritten.
+ * Accepted values:
+ * <ul>
+ * <li>{@code CONTENT} — (default) only overwrite when the content
differs (uses
+ * {@code CachingOutputStream} / {@code CachingWriter}); destination
timestamp is
+ * preserved when the content is identical. This is the behaviour
since 3.4.0.</li>
+ * <li>{@code TIMESTAMP} — only overwrite when the source is newer than
the destination
+ * (timestamp-based, as it was before 3.4.0).</li>
+ * <li>{@code TIMESTAMP_AND_CONTENT} — overwrite only when the source is
newer
+ * <em>and</em> the content differs.</li>
+ * <li>{@code ALWAYS} — always overwrite existing files (equivalent to
the former
+ * {@code <overwrite>true</overwrite>}).</li>
+ * <li>{@code NEVER} — never overwrite an existing destination file.</li>
+ * </ul>
+ *
+ * @since 3.4.0
Review Comment:
⚠️ **Regression (7th review):** `@since 3.4.0` is incorrect — this parameter
is new in this PR. The rebase squashed all commits but used the original value
instead of the fix from `cf0b8a8`. Should be `4.0.0-beta-2`.
```suggestion
* @since 4.0.0-beta-2
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
