gnodet-bot commented on code in PR #2170: URL: https://github.com/apache/maven-resolver/pull/2170#discussion_r4221456453
########## src/site/markdown/release-highlights.md: ########## @@ -0,0 +1,86 @@ +<!-- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + https://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +--> + +# Resolver 2.0.x Notable Features + +This page lists the notable features that the Resolver 2.0.x releases added, up to 2.0.24. +For the full change lists, see the +[GitHub releases](https://github.com/apache/maven-resolver/releases). + +## Transports + +* New HTTP/2 capable `jdk` (Java HTTP client) and `jetty` transports. + Both support HTTP/3 (since 2.0.21). +* Native S3 transport +* File transport can read ZIP files, "mount" them, and use as (read only) remote repository. Review Comment: 💡 Two small grammar issues: missing article "a" before "(read-only)" and "read only" should be hyphenated as a compound adjective. ```suggestion * File transport can read ZIP files, "mount" them, and use as a (read-only) remote repository. ``` ########## src/site/markdown/release-highlights.md: ########## @@ -0,0 +1,86 @@ +<!-- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + https://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +--> + +# Resolver 2.0.x Notable Features + +This page lists the notable features that the Resolver 2.0.x releases added, up to 2.0.24. +For the full change lists, see the +[GitHub releases](https://github.com/apache/maven-resolver/releases). + +## Transports + +* New HTTP/2 capable `jdk` (Java HTTP client) and `jetty` transports. + Both support HTTP/3 (since 2.0.21). +* Native S3 transport Review Comment: 💡 Missing trailing period — every other simple bullet in this file ends with a period. ```suggestion * Native S3 transport. ``` ########## src/site/site.xml: ########## @@ -37,6 +37,7 @@ under the License. <menu name="Guides"> <item name="API Compatibility" href="api-compatibility.html"/> <item name="Upgrading Resolver" href="upgrading-resolver.html"/> + <item name="Resolver 2.0.x Features" href="release-highlights.html"/> Review Comment: 💡 Menu label "Resolver 2.0.x Features" doesn't match the page's H1 heading "Resolver 2.0.x Notable Features" — consider aligning them (either add "Notable" here, or drop it from the heading). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
