efegokdemir commented on code in PR #13386:
URL: https://github.com/apache/maven/pull/13386#discussion_r4223467577
##########
maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java:
##########
@@ -238,6 +238,10 @@ public RepositorySystemSession.SessionBuilder
newRepositorySessionBuilder(MavenE
// Resolver's ConfigUtils solely rely on config properties, that is
why we need to add both here as well.
configProps.putAll(request.getSystemProperties());
configProps.putAll(request.getUserProperties());
+ // Auto-discovered prefix files from virtual repositories may describe
only one member repository.
+ // If verification proves such a file incomplete, favour resolving
available artifacts by dropping it.
+ // Explicit user-provided prefix files remain authoritative in
Resolver, and users can override this default.
Review Comment:
Updated in 84e6b04821afb6f7a923e92b3cc51c57491a6cf2. The comment now states
that true drops verified-denied tree entries for incomplete virtual-repository
prefix files and that false restores Resolver fall-through. The targeted
DefaultRepositorySystemSessionFactoryTest passes (7 tests). The default itself
remains unchanged pending Resolver and Maven maintainer alignment.
##########
maven-core/src/test/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactoryTest.java:
##########
@@ -116,6 +120,35 @@ void malformedServerRepositoryOriginIsIgnored() throws
Exception {
assertNull(selector.getAuthentication(repository("internal",
"https://repo.example.org/releases/";)));
}
+ @Test
+ void
dropsAnAutoDiscoveredPrefixesFileWhenItDeniesAnExistingPathByDefault() throws
Exception {
Review Comment:
Renamed to configuresVerifyDeniedDropsTreeTrueByDefault, which describes the
configuration property assertion rather than Resolver runtime behaviour. The
targeted DefaultRepositorySystemSessionFactoryTest passes (7 tests).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
