ascheman commented on code in PR #466:
URL:
https://github.com/apache/maven-install-plugin/pull/466#discussion_r4235300229
##########
src/main/java/org/apache/maven/plugins/install/InstallMojo.java:
##########
@@ -267,6 +268,11 @@ private ArtifactInstallerRequest processProject(Project
project) {
getLog().warn("");
getLog().warn("Incomplete projects like this will
fail in future Maven versions!");
getLog().warn("");
+ // The main artifact has no file (its path is e.g.
the output directory of a module
+ // source hierarchy, where the JAR plugin attaches
one JAR per Java module instead).
+ // Install the POM and the attachments only; do
not hand the directory to the installer,
+ // which would otherwise fail with "is a folder".
+ toInstall.remove(installable);
Review Comment:
Addressed: replaced the misleading "will fail in future Maven versions"
warning with an informational log message on the remove path — when the
directory-backed main artifact is skipped, it now says the POM and attachments
are installed only. Applied the same to maven-deploy-plugin#717 for
consistency. Thanks for the catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
