adangel commented on code in PR #745:
URL: https://github.com/apache/maven-pmd-plugin/pull/745#discussion_r4240945999
##########
src/test/java/org/apache/maven/plugins/pmd/PmdViolationCheckMojoOnLinuxTest.java:
##########
@@ -141,4 +159,36 @@ public void testViolationExclusion(PmdViolationCheckMojo
mojo) throws Exception
// this call shouldn't throw an exception, as the classes with
violations have been excluded
mojo.execute();
}
+
+ @Basedir("/unit/default-configuration")
+ @InjectMojo(goal = "check", pom =
"pmd-check-failandwarnonpriority-plugin-config.xml")
+ @MojoParameter(name = "siteDirectory", value = "src/site")
+ @MojoParameter(name = "targetDirectory", value = "pmd-report")
+ @MojoParameter(name = "printFailingErrors", value = "true")
Review Comment:
I think, we should also add
```
@MojoParameter(name = "verbose", value = "true")
```
here, as otherwise, we wouldn't test this case, where both verbose=true and
printFailingErros=true
##########
src/test/java/org/apache/maven/plugins/pmd/PmdViolationCheckMojoOnLinuxTest.java:
##########
@@ -141,4 +159,36 @@ public void testViolationExclusion(PmdViolationCheckMojo
mojo) throws Exception
// this call shouldn't throw an exception, as the classes with
violations have been excluded
mojo.execute();
}
+
+ @Basedir("/unit/default-configuration")
+ @InjectMojo(goal = "check", pom =
"pmd-check-failandwarnonpriority-plugin-config.xml")
+ @MojoParameter(name = "siteDirectory", value = "src/site")
+ @MojoParameter(name = "targetDirectory", value = "pmd-report")
+ @MojoParameter(name = "printFailingErrors", value = "true")
Review Comment:
Ah, okay, this is in pmd-check-failandwarnonpriority-plugin-config.xml
already...
I think, I'll add a comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
