elharo commented on code in PR #709:
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/709#discussion_r4247938346
##########
src/main/java/org/apache/maven/plugins/checkstyle/exec/DefaultCheckstyleExecutor.java:
##########
@@ -219,16 +221,15 @@ public CheckstyleResults
executeCheckstyle(CheckstyleExecutorRequest request)
message.append(" ruleset.");
if (request.isFailsOnError()) {
- // TODO: should be a failure, not an error. Report is not
meant to
Review Comment:
How sure are we that the TODO comment is accurate? There is a test for
exactly this behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
