gnodet-bot commented on PR #13094: URL: https://github.com/apache/maven/pull/13094#issuecomment-6170764997
π‘ **Rebase heads-up β `LightweightApiArtifact` will need noun-style accessor migration** `LightweightApiArtifact` currently implements `getGroupId()`, `getArtifactId()`, `getClassifier()`, `getExtension()` β which are still abstract on the PR branch's base but were migrated to deprecated defaults on master (with `groupId()`, `artifactId()`, etc. now being the abstract methods). After rebasing onto current master, the class will fail to compile: `groupId()` / `artifactId()` etc. are abstract and unimplemented. The `key()` override also calls `getGroupId()` etc., which after migration will produce `AbstractMethodError` (the default `getGroupId()` delegates to `groupId()`, which is unimplemented). When rebasing, rename: - `getGroupId()` β `groupId()` - `getArtifactId()` β `artifactId()` - `getExtension()` β `extension()` - `getClassifier()` β `classifier()` - `getVersion()` / `getBaseVersion()` β `version()` / `baseVersion()` (return type changes to `Version` β check if that's still the case on master) - Update `key()` to call the noun-style methods directly _This comment was generated by an AI agent, HermΓ¨s on behalf of @gnodet._ <!-- reviewer: gnodet-bot --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
