arturobernalg opened a new pull request, #13571: URL: https://github.com/apache/maven/pull/13571
## What and why Since 3.10.0, a model built below `VALIDATION_LEVEL_MAVEN_2_0` is treated as a repository POM: its profiles are activated in a sandbox that hides user properties and file activation. `maven.model.dependencyInterpolation.full=true` is documented as the way to opt out, but it was only honoured by the interpolator. Profile activation ignored it, so a project built at `MINIMAL` with the flag set still lost its property-activated profiles (#13347). ## How `DefaultModelBuilder.isExternalModelBuildingRequest` now also checks the flag, through a shared `AbstractStringBasedModelInterpolator.isFullExternalInterpolation`, so interpolation and activation agree. The flag can be a system or a user property. A POM's own `<properties>` still do not activate its profiles (#13390). An explicit marker on the request, set by the artifact descriptor reader instead of inferring it from the validation level, would also fix tools that build projects at `MINIMAL` without the flag. I left that for a separate change. ## Tests Two new tests in `ResolvedDependencyProfileActivationTest` fail without the change. `maven-model-builder` and `maven-core` pass (420 tests) and spotless is clean. I did not run the integration tests. --- To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0) check one of the following: - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0) - [x] I hereby declare that I have filed an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
