gnodet-bot commented on code in PR #13559:
URL: https://github.com/apache/maven/pull/13559#discussion_r4294281626
##########
its/core-it-suite/src/test/resources/mng-1088/plugin/pom.xml:
##########
@@ -57,17 +48,15 @@ under the License.
</dependencies>
<build>
- <resources>
- <resource>
- <directory>.</directory>
- <includes>
- <include>pom.xml</include>
- <include>src/**</include>
- </includes>
- </resource>
- <resource>
- <directory>src/main/resources</directory>
- </resource>
- </resources>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-plugin-plugin</artifactId>
+ <version>4.0.0-beta-1</version>
Review Comment:
⚠️ Hardcoded `maven-plugin-plugin:4.0.0-beta-1` will rot. Other ITs in this
suite (e.g. `mng-8525-maven-di-plugin`) extract this to a local property. Add a
`<properties>` entry and reference it here:
```suggestion
<version>${mavenPluginPluginVersion}</version>
```
Also add `<mavenPluginPluginVersion>4.0.0-beta-1</mavenPluginPluginVersion>`
(or the current GA) to the POM's `<properties>` block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
