gnodet-bot commented on code in PR #13568:
URL: https://github.com/apache/maven/pull/13568#discussion_r4294138320


##########
impl/maven-core/src/main/java/org/apache/maven/project/artifact/AttachedArtifact.java:
##########
@@ -139,7 +139,8 @@ public void setScope(String scope) {
 
     @Override
     public String getVersion() {
-        return parent.getVersion();
+        // the superclass constructor validates its arguments, and builds the 
error message, before the parent is set

Review Comment:
   💡 **Nit:** Minor clarity improvement — `'before the parent field is set'` is 
slightly more precise than `'before the parent is set'`, since `parent` is also 
a parameter name in the constructor. Fine as-is.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to