gnodet-bot commented on code in PR #1217:
URL:
https://github.com/apache/maven-plugin-tools/pull/1217#discussion_r4294370858
##########
maven-plugin-report-plugin/src/it/plugin-report-400/verify.groovy:
##########
@@ -17,8 +17,8 @@
* under the License.
*/
-assert new File( basedir, 'target/site/noop-mojo.html' ).isFile()
-assert new File( basedir, 'target/site/report-mojo.html' ).isFile()
+assert new File( basedir, 'target/site/noop-goal.html' ).isFile()
+assert new File( basedir, 'target/site/report-goal.html' ).isFile()
Review Comment:
💡 **Missing redirect assertions (not blocking)**
The `plugin-report` IT now asserts that the legacy `-mojo.html` redirect
files exist and point to the new `-goal.html` pages (e.g. `assert new
File(basedir, 'target/site/noop-mojo.html').text.contains('noop-goal.html')`).
This IT only checks that the new `-goal.html` files exist but doesn't verify
the redirect files are created.
Consider adding similar redirect assertions here for consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
