gnodet-bot commented on code in PR #13569:
URL: https://github.com/apache/maven/pull/13569#discussion_r4301557076
##########
impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/mvnup/goals/AbstractUpgradeStrategy.java:
##########
@@ -255,7 +266,7 @@ protected void logSummary(UpgradeContext context,
UpgradeResult result) {
context.println();
context.info(getDescription() + " Summary:");
context.indent();
- context.info(result.modifiedCount() + " POM(s) modified");
+ context.info(result.modifiedCount() + (context.isDryRun() ? " POM(s)
would be modified" : " POM(s) modified"));
Review Comment:
⚠️ **Pluralization inconsistency still open**: `logSummary()` uses `"POM(s)
would be modified"` here, but `logStrategyResult()` and `logOverallResult()` in
`StrategyOrchestrator` both use `"POMs"`. The previous review flagged
inconsistency between the two code paths — this commit fixed the orchestrator
but left `logSummary()` on the old form.
Pick one and align. `POMs` is simpler and already dominant across both files:
```suggestion
context.info(result.modifiedCount() + (context.isDryRun() ? " POMs
would be modified" : " POMs modified"));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
