gnodet-bot commented on code in PR #13607: URL: https://github.com/apache/maven/pull/13607#discussion_r4306601052
########## impl/maven-impl/src/test/resources/settings/settings-xml-markup-interpolation.xml: ########## @@ -0,0 +1,40 @@ +<?xml version="1.0" encoding="UTF-8"?> + +<!-- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +--> + +<!-- + Settings file that uses a property whose value contains XML special characters + (e.g. &, <, >) to verify that interpolateSource() XML-escapes resolved values + before substituting them into the raw XML string (MNG-4625 regression test). +--> +<settings xmlns="http://maven.apache.org/SETTINGS/1.0.0";> + <profiles> + <profile> + <id>xml-markup</id> + <properties> + <!-- test.prop resolves to something with XML markup like "&x=y<>" --> Review Comment: 💬 **Nit — misleading comment.** The property *value* is `&x=y<>` (raw characters), not `&x=y<>`. The comment shows the XML-escaped form without explaining it's escaped, which a reader could misinterpret as the actual Java property value already containing entities. Consider: ```suggestion <!-- test.prop value is "&x=y<>" (raw, contains XML special characters) --> ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
