Shreekar-cloud commented on PR #13601:
URL: https://github.com/apache/maven/pull/13601#issuecomment-6257785893
Thanks for applying that, @abdulhannansyed548-cmd. I checked out the current
head of this PR (aeb6dc1) and ran the regression test, and I found two small
things that would likely stop CI from going green:
1. testLocalParentResolutionWithValidationLevels still fails for
processPlugins=false. After the review’s request to keep the isProcessPlugins()
guard, a processPlugins=false build is a consumer request again, and consumer
requests never look for a local parent. So builder.build(...) throws
Non-resolvable parent POM ... test:parent:pom:1 (absent) at
ProjectBuilderTest.java:325 before any assertion runs. The updated expected
value doesn’t help because the build throws before it’s checked. I changed the
loop to for (boolean processPlugins : List.of(true)) (and nothing else), and
with that the test passes: Tests run: 1, Failures: 0, Errors: 0. The remaining
matrix is MINIMAL and STRICT with processPlugins=true, which are the
combinations where a local parent is expected.
2. Formatting. When I ran the build locally, the formatter rewrote the type
assignment in DefaultProjectBuilder.prepare(). This is the formatted version,
with the same logic:
java
ModelBuilderRequest.RequestType type =
reactorMember || isStandalone || (pomFile != null &&
request.isProcessPlugins())
? ModelBuilderRequest.RequestType.BUILD_EFFECTIVE
: (parent
? ModelBuilderRequest.RequestType.CONSUMER_PARENT
:
ModelBuilderRequest.RequestType.CONSUMER_DEPENDENCY);
Running mvn spotless:apply (or any normal build) will apply it. The bot’s
earlier note about the missing blank line before the getValidationLevel()
Javadoc in ModelBuilderRequest.java is still open too.
Caveat: I only ran that one test on your branch, not the full suite, so CI
is still the real check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
