arturobernalg commented on code in PR #2210:
URL: https://github.com/apache/maven-resolver/pull/2210#discussion_r4313408922
##########
maven-resolver-api/src/main/java/org/eclipse/aether/transfer/ChecksumFailureException.java:
##########
@@ -48,6 +52,7 @@ public class ChecksumFailureException extends
RepositoryException {
* @param expected The expected checksum as declared by the hosting
repository, may be {@code null}.
* @param expectedKind The expected checksum kind, may be {@code null}.
* @param actual The actual checksum as computed from the local bytes, may
be {@code null}.
+ * @return The new exception, never {@code null}.
Review Comment:
I checked the actual pushed file: in all four methods `@return` is already
on the line immediately before `@since` (e.g. lines 55-56 for `mismatch()`:
`@return` then `@since 2.0.19`), not after it. The diff hunk in this comment
only shows the pure addition of the `@return` line relative to the pre-existing
`@param`/`@since` lines, so the ordering looks correct to me as committed.
I also ran `JAVA_HOME=<jdk-26> mvn -pl maven-resolver-api clean
javadoc:javadoc` against the current commit and it reports 0 warnings, so
there's no doclint tag-order warning being produced here either.
Also note the suggested replacement duplicates `@param actual` and `@since
2.0.19` (both already present just above/below), so applying it as-is would
introduce a duplicate-tag problem. Leaving this one as-is unless I'm missing
something — happy to adjust if you can point to the specific line where the
order is actually wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
