gnodet-bot commented on code in PR #13633:
URL: https://github.com/apache/maven/pull/13633#discussion_r4317210807
##########
api/maven-api-xml/src/main/java/org/apache/maven/api/xml/XmlNode.java:
##########
@@ -343,6 +343,10 @@ static XmlNode merge(@Nullable XmlNode dominant, @Nullable
XmlNode recessive) {
return XmlService.merge(dominant, recessive, null);
}
+ /**
+ * @deprecated Use {@link XmlService#merge(XmlNode, XmlNode, Boolean)}
instead.
+ */
Review Comment:
💡 **Nit:** The Javadoc on the deprecated method is a stub — only
`@deprecated` with no `@param`, `@return`, or `@throws`. The two-arg sibling
just above has complete Javadoc. For consistency and so IDEs/tooling can
surface the full contract alongside the deprecation warning, please add the
missing tags:
```suggestion
/**
* @param dominant the node
* @param recessive if {@code null}, nothing will happen
* @param childMergeOverride overrides child merge behavior
* @return the merged node
* @deprecated Use {@link XmlService#merge(XmlNode, XmlNode, Boolean)}
instead.
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
