charangowdamd-cmd opened a new pull request, #13634:
URL: https://github.com/apache/maven/pull/13634

   Fixes #13629
   
   ## Summary
   
   - Formally deprecate `XmlNode.merge(XmlNode, XmlNode, Boolean)` with 
`@Deprecated(since = "4.0.0", forRemoval = true)` to steer callers towards 
`XmlService.merge(...)`.
   - Deprecate `XmlNodeImpl.merge(XmlNode, XmlNode, Boolean)` in the 
implementation.
   - Migrate the only in-tree caller in `MojoExtension` to 
`XmlService.merge(...)`.
   - Add unit tests in `XmlNodeImplTest` verifying deprecation annotation and 
functional delegation.
   
   ## Verification
   
   - `mvn spotless:check` passed across all 38 modules.
   - `mvn test -pl :maven-api-xml,:maven-xml,:maven-testing` passed (59 XML 
tests and 25 testing module tests passed).
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
    - [x] make sure this is not a duplicate of an existing PR
    - [x] choose a fine-grained feature branch
    - [x] choose a meaningful title
    - [x] verify that the tests pass
    - [x] update documentation
    - [ ] check and update dependencies
   
   ---
   
   - [x] I hereby declare this contribution to be licensed under the [Apache 
License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0)
   - [ ] I hereby declare that I have filed an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to