gnodet commented on PR #11904: URL: https://github.com/apache/maven/pull/11904#issuecomment-6300475510
@linghengqian Not TCP handshakes, just iterative review cycles 😄 Each approval corresponds to a distinct push by the contributor that addressed findings from the previous review pass: - 1st approval (Sep 10): after the type-check inconsistency between normalizer and consumer POM builder was fixed - 2nd approval (Sep 24): docs-only push (EXPECT comments on XML fixtures) — no behavior change, previous approval rationale still valid - 3rd approval (Oct 20): after the off-by-one thresholds in the type/classifier conflict checks and the dedup key semantics were fixed GitHub dismisses a previous approval when new commits are pushed, so each round of fixes requires a fresh approval to keep the `reviewDecision: APPROVED` state. The bot re-reviews each push and approves again if the findings are resolved. Three pushes addressing findings → three approvals. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
