slachiewicz opened a new pull request, #886: URL: https://github.com/apache/maven-shade-plugin/pull/886
`ShadeMojoTest` was the last test on the JUnit 3 `AbstractMojoTestCase`. It now uses `@MojoTest`, with the container, `Shader`, `ArtifactHandler` and project injected, and the `shade` mojo from `@InjectMojo`. With that, the tests need neither JUnit 4 nor the vintage engine. `ComponentsXmlResourceTransformerTest` moves from `xmlunit-legacy` to `xmlunit-core`. The legacy module brings `junit:3.8.1`, and surefire adds the vintage engine whenever JUnit is on the test classpath, so leaving it would break test discovery. `ignoreComments()` keeps the old result: the only comment in those files is the license header, which the merged output does not carry. Verified: `mvn verify -Dinvoker.skip` → 85 tests, the same per class as on master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
