slachiewicz opened a new issue, #355: URL: https://github.com/apache/maven-fluido-skin/issues/355
Fluido master is still the 2.x line (2.2.0-SNAPSHOT, 40 commits since 2.1.0). Before master moves on to a 3.x rewrite, the 2.x fixes should land and 2.2.0 should be released, so that the `maven-fluido-skin-2.x` maintenance branch starts from a released, tested state. ## Fixes for 2.2.0 - [ ] CI has not checked the integration tests since 1bfb2f7: the second invoker execution (`integration-test-without-cloning`) deletes the reports of the first one before `invoker:verify` runs, so `verify` sees one result and passes. The Verify run on master on 2026-10-29 shows `topbar` and `sidebar` failing, followed by `Passed: 1, Failed: 0` and `BUILD SUCCESS`. Both tests fail since maven-skins 49 replaced `MavenLogoLeafSmall.png` with `MavenLogoLeaf.svg`. - [ ] Without the default "Built by Maven" logo (#329, #338), the box below the sidebar menu is empty on every site that configures no search, social buttons or `poweredBy`. 2.1.0 filled it with the logo, so this is new in 2.2.0. - [ ] #323: a page head that declares `charset`, `viewport` or `generator` produces a second element of each, because the skin writes its own and then appends `$headContent` unchanged. ## Open pull requests - #335 (conditional anchor.js, ribbon CSS, profile images): raises the minimum doxia-sitetools to 2.1.0. If it goes into 2.2.0, it needs the `removed` label so the raised minimum shows in the release notes. - #325 (opt-in dark theme): mergeable; needs an IT, and an answer on the `light-dark()` suggestion. CI has not run on it yet. - #316 (optional `poweredBy`): its motivation is covered by the empty-box fix above, without a new option; the review on it asked for an IT and for search to work without `poweredBy`. - #29 / #239: MSKINS-262 removed the `externalLink` icon rules in 2.1.0, so the sidebar margin problem cannot occur any more. - #65 / #277 (prettify replacement): highlight.js has no line numbers, so the draft drops `sourceLineNumbersEnabled`, which maven-parent enables. Not a maintenance-line change; it belongs to the highlighting decision for 3.x. ## Later 2.x candidates (not in this batch) - #228: jQuery 1.11.2 has known CVEs; a 3.x upgrade needs the Bootstrap 2 top bar and dropdowns tested in a browser. - #333: minify-maven-plugin is unmaintained; the build still works on Maven 3.10 and 4.0.0-rc-7. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
