elharo commented on code in PR #890:
URL:
https://github.com/apache/maven-shade-plugin/pull/890#discussion_r4437438514
##########
src/main/java/org/apache/maven/plugins/shade/PlatformModuleIndex.java:
##########
@@ -100,34 +110,126 @@ private void readHistoricalReleases() throws
MojoExecutionException {
return;
}
try (JarFile archive = new JarFile(ctSym)) {
- Enumeration<JarEntry> entries = archive.entries();
- while (entries.hasMoreElements()) {
- JarEntry entry = entries.nextElement();
+ List<JarEntry> entries = Collections.list(archive.entries());
+ boolean legacyLayout = usesLegacyLayout(entries);
+ for (JarEntry entry : entries) {
Review Comment:
Addressed in 74f1458: legacy module descriptors are now read in a first
pass, class signatures in a second pass, and the synthetic legacy fixture has a
class-first regression case (Parser.sig written before its descriptor).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
