slachiewicz opened a new pull request, #369:
URL: https://github.com/apache/maven-fluido-skin/pull/369

   Bootstrap's link blue `#0088cc` reaches 3.9:1 on white and 3.6:1 on the grey 
sidebar, and its `#999` menu headings and current breadcrumb reach 2.6:1, all 
below the 4.5:1 of WCAG 1.4.3. On maven.apache.org these make up nearly all of 
axe's colour-contrast failures, often 80 to 350 per page. This changes:
   
   * links, linked code and the current menu item's background to `#006da3` 
(5.2:1 on the sidebar);
   * menu headings and the current breadcrumb to `#6c6c6c` (4.8:1).
   
   The darker blue is too close to the body text (`#404040`, `#333`) for colour 
alone to mark a link, so links inside `#bodyColumn` are underlined, except 
buttons. The dark theme keeps its lighter colours, which a dark background 
needs.
   
   Verified: maven-site rendered with this skin, axe-core on 6 pages (home, 
install, Maven in 5 minutes, plugins, repositories, guides) → colour-contrast 
80 to 355 per page → 0, link-in-text-block 9 → 0.
   
   | Before | After |
   |---|---|
   | 
![before](https://github.com/slachiewicz/maven-fluido-skin/blob/pr-screenshots/link-contrast-before.png?raw=true)
 | 
![after](https://github.com/slachiewicz/maven-fluido-skin/blob/pr-screenshots/link-contrast-after.png?raw=true)
 |
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to