slachiewicz opened a new pull request, #13836:
URL: https://github.com/apache/maven/pull/13836
Backport of #13834 (fix #10230) to `maven-4.0.x`.
`mvn --encrypt-password` in the compat `MavenCli` (`compat/maven-embedder`)
read the password only through
`System.console()`, so with redirected streams it encrypted nothing and
printed `{}` (MNG-8398). #13589 fixed this
on 3.9.x and 3.10.x; this is the same change as on master:
`MavenCli.readPassword` falls back to the first line of
the standard input and fails with `No password was provided` when there is
none. `--encrypt-master-password` keeps
failing with "not supported anymore", as before on Maven 4.
## Checklist
- [x] Your pull request should address just one issue, without pulling in
other changes.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied.
The three `MavenCliTest` tests from #13589.
- [x] Run `mvn verify` to make sure basic checks pass.
`compat/maven-embedder`: 48 tests, 0 failures (1 skipped, as before);
spotless clean.
- [ ] You have run the [Core IT][core-its] successfully.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
